-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch integration tests to mirror CLI usage #1179
Conversation
@kevaundray This adds another ~10mins to the ubuntu run (up from 18mins) |
I've separated all the readability improvements into #1180 so we can merge those even in the case we don't go ahead with this change. (plus it will highlight the substantive changes here more clearly) |
Ah thats horrible |
What is the reasoning for the extra 10 minutes of runtime? |
Let's park this pending #1180 |
b38221e
to
97e5bb2
Compare
97e5bb2
to
86cfa3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Related issue(s)
Resolves #1177 (comment)
Description
Summary of changes
This PR changes the integration tests to work using the CLI directly to ensure exact parity between this and real-world usage. i.e. rather than using
prove_and_verify
we actually usenargo prove
andnargo verify
.As part of this I've done some general refactoring as this code is unnecessarily complex (3 layers of nesting to just iterate through test cases).
Dependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Documentation needs
Additional context