feat!: Move WitnessMap type into ACVM to avoid leaking BTreeMap type #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore!: Split filesystem errors off from CliError chore!: Make all run functions take a backend and pass it from the CLI entry
… into phated/acvm-0.12.0
* phated/acvm-0.12.0: (45 commits) chore!: Update to ACVM 0.12.0 official release of backend feat: use dummy constructor for bb call chore: add missing `?` chore: use `try_vecmap` in old `vecmap` locations chore: update `acvm-backend-barretenberg` to 0.1.0 commit latest master fix: improve variable resolution test: re enabled sort test chore: update cargo tomls feat: adapted to heterogeneous bb calls remove unneeded import fix grep problems chore: replace long `Backend` type parameters with `B` update to latest commit chore: Make CliError generic over a Backend chore: Update nargo core to return backend errors chore!: Update to acvm 0.11.0 chore(parser): Parser error optimisation (#1292) chore(ssa refactor): Implement function inlining (#1293) ...
TomAFrench
force-pushed
the
phated/witness-map
branch
from
d545ed1 to
c152a7f
Compare
5 tasks
|
Merging this into #1339 since the witness map change was merged into acvm 0.12 |
phated
force-pushed
the
phated/acvm-0.12.0
branch
from
091fad1 to
e1f5b61
Compare
|
This has now been rolled into #1339 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #
Description
Summary of changes
Consumption of noir-lang/acvm#252 and noir-lang/acvm-backend-barretenberg#152
This also removes the
WitnessMaptype alias in noirc_abi because it is a full type introduced by ACVM.Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context