chore(ssa refactoring): Support basic recursive functions #1387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
The SSA Refactoring could support recursive functions with minimal changes, but does not.
Summary
Supports basic recursive functions in the ssa refactoring. This was a ~6 line change (all other lines are for the new test). This supports only "basic" recursive functions that are able to be evaluated during inlining because of constant folding. We could make this more complex in the future but this should support the majority of use cases as-is. It is also still worth noting that this recursion must (like loops) terminate during compilation so calling a recursive function like
factorial
on a private input will still result in hitting the recursion limit.Example
Before the code:
Will hit the recursion limit in the ssa refactoring (likewise in the current ssa we issue an error stating recursive functions are not supported). After this PR it will inline
factorial
correctly and main will become equivalent to:Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.