Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ssa refactor): Make mapping from the instruction results to AcirVar more explicit/mandatory #1436

Merged
merged 24 commits into from
May 30, 2023
Merged

chore(ssa refactor): Make mapping from the instruction results to AcirVar more explicit/mandatory #1436

merged 24 commits into from
May 30, 2023

Conversation

kevaundray
Copy link
Contributor

@kevaundray kevaundray commented May 29, 2023 •
edited
Loading

Description

This is a small change to ensure that if we return (Vec::new(), Vec::new() we are explicitly stating that an instruction does not return any values.

Problem*

Resolves

Summary*

This PR sets out to

Example

Before:

After:

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

kevaundray added 20 commits May 27, 2023 18:34
@kevaundray
add field mul and div
83de289
@kevaundray
add code to process field mul and div
1ef2ca9
@kevaundray
add assert example
0637626
@kevaundray
add is_equal constraint
18c4274
@kevaundray
add eq_var method for AcirVar
171d5d9
@kevaundray
process Constrain instruction and BinaryOp::Eq
f1bfdc6
@kevaundray
add TODO for more than the maximum number of bits
58edbc9
@kevaundray
add numeric_cast_var method which constrains a variable to be equal t…
3c8c901 
…o a NumericType
@kevaundray
implement casting for numeric types
a58f7a4
@kevaundray
add simple range constraint example
ca60032
@kevaundray
add constraints for more_than_eq
fbdfefa
@kevaundray
- add more_than_eq method
327c2f6 
- This method needs to know the bit size, so we cache this information whenever we do a range constraint.
We should ideally also cache it for constants too since we can figure out their bit-sizes easily
@kevaundray
add method to process less than binary operation
90c2102
@kevaundray
add example
99f414b
@kevaundray
assign result of cast operation
8d7f7f9
@kevaundray
Merge branch 'kw/range-constraints' into kw/add-comparison
a7f1178
@kevaundray
add y as an input value
6b159ee
@kevaundray
return optimized circuit
1c2cee5
@kevaundray
Merge branch 'kw/add-optimized-circuit' into kw/add-comparison
b935436
@kevaundray
refactor code so that mapping of the ValueIds to AcirVar is more expl…
a8e35d8 
…icit. This way we need to explicitly mark instructions as not returning anything.
@kevaundray kevaundray marked this pull request as ready for review May 29, 2023 18:32
joss-aztec
joss-aztec approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@joss-aztec joss-aztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@kevaundray kevaundray mentioned this pull request May 30, 2023
Closed
Base automatically changed from kw/add-comparison to master May 30, 2023 19:15
@kevaundray kevaundray added this pull request to the merge queue May 30, 2023
@kevaundray kevaundray mentioned this pull request May 30, 2023
Merged
5 tasks
Merged via the queue into master with commit eae624b May 30, 2023
@kevaundray kevaundray deleted the kw/make-instruction-results-mapping-mandatory branch May 30, 2023 22:29
kevaundray added a commit that referenced this pull request May 31, 2023
@kevaundray
Revert "chore(ssa refactor): Make mapping from the instruction result…
a8ad8a1 
…s to AcirVar more explicit/mandatory (#1436)"

This reverts commit eae624b.
@kevaundray kevaundray mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher left review comments

@joss-aztec joss-aztec joss-aztec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevaundray @jfecher @joss-aztec