-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ssa refactor): acir-gen arrays in main #1455
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
reviewed
May 30, 2023
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/memory.rs
Outdated
Show resolved
Hide resolved
kevaundray
reviewed
May 30, 2023
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/acir_variable.rs
Show resolved
Hide resolved
kevaundray
reviewed
May 30, 2023
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/memory.rs
Outdated
Show resolved
Hide resolved
kevaundray
reviewed
May 30, 2023
joss-aztec
commented
May 31, 2023
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/acir_variable.rs
Show resolved
Hide resolved
jfecher
reviewed
May 31, 2023
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/memory.rs
Outdated
Show resolved
Hide resolved
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/memory.rs
Outdated
Show resolved
Hide resolved
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/memory.rs
Outdated
Show resolved
Hide resolved
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/memory.rs
Outdated
Show resolved
Hide resolved
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/memory.rs
Outdated
Show resolved
Hide resolved
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/memory.rs
Outdated
Show resolved
Hide resolved
jfecher
approved these changes
May 31, 2023
kevaundray
reviewed
May 31, 2023
kevaundray
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is okay for me too, and we can iterate on it in further PRs -- had a question RE the recursive method, but I think we can just refactor it if need be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary*
Adds support for arrays found in parameters to main, and load instructions there from.
Example
compiles to
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.