-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nargo): Add lsp
command to start server that reports no capabilities
#1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
reviewed
Jun 6, 2023
One nit: To be consistent, can you add a header in https://github.com/noir-lang/noir/blob/master/crates/readme.md with the lsp since it a new crate |
@kevaundray that's done, but the readme.md file is very out of date and still references acvm/acir and is missing other crates. |
TomAFrench
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR puts in place the scaffolding for the LSP server logic via
nargo_lsp
crate and then constructs a Tower stack via thelsp
command innargo_cli
. The LSP currently reports no capabilities, but serves as the skeleton to prove that noir-lang/vscode-noir#3 can communicate with it (enable tracing in the options).The choice to use
async-lsp
was made because it sets out to solve a bunch of tower-lsp problems.Documentation
This PR requires documentation updates when merged.
This will add an additional command to the Nargo CLI and we will need to update the docs to mention the VSCode extension that provides the LSP client.
Additional Context
PR Checklist*
cargo fmt
on default settings.