chore(errors): Remove span end offset to surface problems

[phated]

Description

Problem*

Resolves

Summary*

This removes the + 1 offset on span ends. This will allow us to have a clear understanding of where span start/ends might be wrong in the compiler. I first noticed this off-by-one when outputting diagnostics via the LSP and will open a follow-up issue to fix the spans in the compiler.

Documentation

• This PR requires documentation updates when merged.

  • I will submit a noir-lang/docs PR.
  • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[kevaundray]

Since this doesn't produce any errors, we should check where the errors/problems are and fix them in this PR too instead of merging this in as is

[phated]

Since this doesn't produce any errors, we should check where the errors/problems are and fix them in this PR too instead of merging this in as is

The purpose of opening this PR is so we can get issues reported for the various places this is a problem in the compiler. There could be tens/hundreds of these and I'm unfamiliar where these problems exist in the compiler so I'm looking to @kevaundray and @jfecher to fix these. Feel free to push on this PR.

[jfecher]

I mentioned possibly more sources for error in the standup but I'm anticipating the lexer to be the one at fault here since it assigns spans to tokens to begin with. I haven't investigated yet but I'm assuming it issues inclusive-end spans when we'd want exclusive-end instead.