chore(ssa refactor): Handle Brillig calls #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: guipublic <47281315+guipublic@users.noreply.github.com> Co-authored-by: ludamad <adam.domurad@gmail.com>
Co-authored-by: ludamad <adam.domurad@gmail.com>
…_id_to_block_id through necessary functions
- remove magic constant - use mov_instruction method
kevaundray
commented
Jun 18, 2023
* fix: entry point and exit point handling * feat: function linking * docs: added comments * docs: more comments
|
Ah, my bad with |
|
Changes look okay to me -- going to give it a once over again tomorrow, then we can open an issue re jumps in function calls |
kevaundray
changed the title
|
@sirasistant Looks good to me, can you approve? |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
sirasistant
approved these changes
Jun 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Had to add it to the merge queue again because seems like some CI step stalled and didn't give output |
|
I keep looking and being surprised this isnt in master :D |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.