Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: recursion working in brillig #1854

Merged
merged 6 commits into from
Jul 4, 2023
Merged

feat: recursion working in brillig #1854

merged 6 commits into from
Jul 4, 2023

Conversation

sirasistant
Copy link
Contributor

Description

Problem*

Adds recursion support by creating entry point artifacts as independent artifacts that jump to the first function called.

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@sirasistant sirasistant requested review from ludamad and kevaundray July 4, 2023 08:43
ludamad
ludamad previously approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sirasistant sirasistant enabled auto-merge July 4, 2023 09:38
kevaundray
kevaundray previously approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, just comment change

@sirasistant sirasistant added this pull request to the merge queue Jul 4, 2023
@kevaundray kevaundray removed this pull request from the merge queue due to a manual request Jul 4, 2023
kevaundray
kevaundray previously approved these changes Jul 4, 2023
View reviewed changes
@kevaundray kevaundray enabled auto-merge July 4, 2023 14:51
@kevaundray kevaundray added this pull request to the merge queue Jul 4, 2023
Merged via the queue into master with commit e55b5a8 Jul 4, 2023
@kevaundray kevaundray deleted the arv/brillig_recursion branch July 4, 2023 18:18
@kevaundray kevaundray mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

@ludamad ludamad ludamad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirasistant @ludamad @kevaundray