Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib): Add secp256r1 builtin function #1858

Merged
merged 13 commits into from
Jul 10, 2023
Merged

feat(stdlib): Add secp256r1 builtin function #1858

merged 13 commits into from
Jul 10, 2023

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Jul 4, 2023 •
edited
Loading

Description

Adds secp256r1 signature verification to the standard library.

TODO

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@Maddiaa0 Maddiaa0 force-pushed the md/hackathon branch 2 times, most recently from 4d2b62c to 8fb2ffd Compare July 8, 2023 13:24
@Maddiaa0 Maddiaa0 marked this pull request as ready for review July 8, 2023 13:34
@TomAFrench
Copy link
Member

Can be merged after #1897

TomAFrench
TomAFrench requested changes Jul 10, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
TomAFrench
TomAFrench approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomAFrench TomAFrench enabled auto-merge July 10, 2023 10:53
@TomAFrench TomAFrench added this pull request to the merge queue Jul 10, 2023
Merged via the queue into master with commit f3800c5 Jul 10, 2023
@TomAFrench TomAFrench deleted the md/hackathon branch July 10, 2023 11:17
@kevaundray kevaundray mentioned this pull request Jul 10, 2023
Merged
@Savio-Sou Savio-Sou mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray left review comments

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Maddiaa0 @TomAFrench @kevaundray @Savio-Sou