-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Save witness in correct format that bb.js expects #1876
Conversation
…ckend-barretenberg dep to show all old CI passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks any interop with the ACVM simulator. bb.js should update to accept the witness map format defined by ACIR.
Ah didn't realize this would break ACVM simulator. I switched this to a feature flag |
@TomAFrench could you open an issue for it on https://github.com/AztecProtocol/barretenberg/? |
This has now been put behind a feature flag
Reminder that we should not merge PRs which rely on patched versions of our own packages. This PR should have used the 0.6.1 release of Using a commit which wasn't in master for |
Description
We are moving to have our ACIR tests run in bb.js for proving and verification while nargo will just handle circuit execution.
Problem*
Resolves
Summary*
This PR changes the format in which witnesses are saved to file. bberg is currently the only consumer of our witness output however this may be breaking for any old programs that still save the witness to file and use it elsewhere (however I see this as unlikely due to the large divergence in the TS bberg packages and Noir master).
In order to be in line with bb.js we also need to enable the RecursiveAggregation opcode in acvm-backend-barretenberg as per this PR: noir-lang/acvm-backend-barretenberg#225
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.