Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Remove mac runner #1885

Merged
merged 1 commit into from
Jul 7, 2023
Merged

chore(ci): Remove mac runner #1885

merged 1 commit into from
Jul 7, 2023

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Jul 7, 2023

Description

The Mac runner in this PR #1728 fails with a pointer being freed was not allocated error coming from barretenberg. However, all tests pass on my local intel Mac and other's ARM Mac laptops.

We also have moved to just performing execution in the prove_and_verify tests w/ barretenberg handling proving and verification. The error is still happening after the move execution, thus there is most likely some internal bug w/ barretenberg on the Mac runner.

This is blocking slices which is blocking a lot of other work by others, so we are going to remove the Mac runner and create an issue to barretenberg to handle running Noir tests on the different architectures.

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray added this pull request to the merge queue Jul 7, 2023
Merged via the queue into master with commit 26d078d Jul 7, 2023
@kevaundray kevaundray deleted the mv/remove-mac-runner branch July 7, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants