Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add nargo build as alias for nargo compile #1940

Merged
merged 3 commits into from
Jul 18, 2023
Merged

feat: Add nargo build as alias for nargo compile #1940

merged 3 commits into from
Jul 18, 2023

Conversation

Andy53
Copy link
Contributor

@Andy53 Andy53 commented Jul 16, 2023

Description

Problem*

Adds an alias "build" for the "compile" command. Fixes #1882

Resolves: #1882

Summary*

Adds a command to Nargo called "build" with the exact same implementation as "compile"
No breaking changes.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

This change will require documenting that build is a command with the same functionality as compile.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@Andy53 Andy53 changed the title added build as alias for compile fix: added build as alias for compile Jul 16, 2023
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making a PR @Andy53. I've got one note on how we can get clap to handle this alias for us.

crates/nargo_cli/src/cli/mod.rs Outdated Show resolved Hide resolved
@TomAFrench TomAFrench changed the title fix: added build as alias for compile feat: Add nargo build as alias for nargo compile Jul 17, 2023
@TomAFrench TomAFrench enabled auto-merge July 17, 2023 20:53
@TomAFrench TomAFrench added this pull request to the merge queue Jul 17, 2023
Merged via the queue into noir-lang:master with commit 13618d4 Jul 18, 2023
@Andy53 Andy53 deleted the add_build_alias_for_compile branch July 21, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alias compile with build
3 participants