Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: method resolution when calling an &mut method with an &mut object type #1947

Merged
merged 2 commits into from
Jul 18, 2023
Merged

fix: method resolution when calling an &mut method with an &mut object type #1947

merged 2 commits into from
Jul 18, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Jul 17, 2023

Description

Problem*

Resolves #1946

Summary*

This was a simple missed case in lookup_method for handling the MutableReference type. More details are given in the linked issue.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher changed the title fix: Fix method resolution when calling an &mut method with an &mut object type fix: Fixed method resolution when calling an &mut method with an &mut object type Jul 17, 2023
@jfecher jfecher changed the title fix: Fixed method resolution when calling an &mut method with an &mut object type fix: method resolution when calling an &mut method with an &mut object type Jul 17, 2023
ludamad
ludamad approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfecher jfecher enabled auto-merge July 17, 2023 21:15
@TomAFrench TomAFrench disabled auto-merge July 17, 2023 22:37
@TomAFrench TomAFrench enabled auto-merge July 17, 2023 22:37
@TomAFrench TomAFrench added this pull request to the merge queue Jul 17, 2023
Merged via the queue into master with commit 73c2e94 Jul 18, 2023
@TomAFrench TomAFrench deleted the jf/fix-1946 branch July 18, 2023 00:21
@kevaundray kevaundray mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mutable references bug? I can't cook my potatoes!!!
3 participants
@jfecher @ludamad @TomAFrench