feat: Initial work on rewriting closures to regular functions with hi…#1959

Merged

jfecher merged 26 commits intonoir-lang:masterfrom metacraft-labs:reformed-closures

Aug 2, 2023

+1,078-125

Commits on Aug 2, 2023

feat: Initial work on rewriting closures to regular functions with hidden env
alehander92
committed
refactor: use panic, instead of println+assert

alehander92
and
jfecher
committed
test: add an initial monomorphization rewrite test
alehander92
committed
fix: address some PR comments: comment/refactor/small fixes
alehander92
committed
fix: use an unified Function object, fix some problems, comments
alehander92
committed
fix: fix code, addressing cargo clippy warnings
alehander92
committed
fix: replace type_of usage and remove it, as hinted in review
alehander92
committed
test: move closure-related tests to test_data
alehander92
committed
test: update closure rewrite test output
alehander92
committed
chore: apply cargo fmt changes
alehander92
committed
test: capture some variables in some tests, fix warnings, add a TODO
alehander92
committed
test: add simplification of noir-lang#1088 as a resolve test, enable another test
alehander92
committed
fix: fix unify for closures, fix display for fn/closure types
alehander92
committed
test: update closure tests after resolving mutable bug
alehander92
committed
fix: address some review comments for closure PR: fixes/cleanup
alehander92
committed
refactor: cleanup, remove a line

alehander92
and
jfecher
committed
refactor: cleanup

alehander92
and
jfecher
committed
fix: fix bind_function_type env_type handling type variable binding
alehander92
committed
test: improve higher_order_fn_selector test
alehander92
committed
fix: remove skip_params/additional param logic from typechecking/display
alehander92
committed
fix: don't use closure capture logic for lambdas without captures

Alex Vitkov
authored and
alehander92
committed
fix: apply cargo fmt & clippy

Alex Vitkov
authored and
alehander92
committed
chore: apply cargo fmt
alehander92
committed
test: fix closure rewrite test: actually capture
alehander92
committed
chore: remove type annotation for params
alehander92
committed
chore: run cargo fmt
alehander92
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Initial work on rewriting closures to regular functions with hi…#1959

Commits on Aug 2, 2023

feat: Initial work on rewriting closures to regular functions with hidden env

refactor: use panic, instead of println+assert

test: add an initial monomorphization rewrite test

fix: address some PR comments: comment/refactor/small fixes

fix: use an unified Function object, fix some problems, comments

fix: fix code, addressing `cargo clippy` warnings

fix: replace type_of usage and remove it, as hinted in review

test: move closure-related tests to test_data

test: update closure rewrite test output

chore: apply cargo fmt changes

test: capture some variables in some tests, fix warnings, add a TODO

test: add simplification of noir-lang#1088 as a resolve test, enable another test

fix: fix unify for closures, fix display for fn/closure types

test: update closure tests after resolving mutable bug

fix: address some review comments for closure PR: fixes/cleanup

refactor: cleanup, remove a line

refactor: cleanup

fix: fix bind_function_type env_type handling type variable binding

test: improve higher_order_fn_selector test

fix: remove skip_params/additional param logic from typechecking/display

fix: don't use closure capture logic for lambdas without captures

fix: apply cargo fmt & clippy

chore: apply cargo fmt

test: fix closure rewrite test: actually capture

chore: remove type annotation for `params`

chore: run cargo fmt