Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): Add Compile code lens for main function and contracts #2309

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Aug 14, 2023

Description

Problem*

Another implementation of #1834

Summary*

This adds a > Compile code lens above contracts (in contract packages) and main functions (in bin packages). Currently a draft because it relies on #2308 and it outputs the artifacts in each package in a workspace instead of at the workspace root (so I want to solve that problem first).

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Base automatically changed from phated/module-locations to master August 14, 2023 20:27
@phated phated force-pushed the phated/compile-lens branch from cd67fc0 to 4c8dae1 Compare August 15, 2023 20:03
@phated phated marked this pull request as ready for review August 15, 2023 20:26
@phated phated requested review from TomAFrench and kobyhallx August 15, 2023 20:26
@phated
Copy link
Contributor Author

phated commented Aug 15, 2023

We also need to merge noir-lang/vscode-noir#30 to support the command.

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and I could compile programs using this.

@phated phated added this pull request to the merge queue Aug 16, 2023
Merged via the queue into master with commit 5fe69c6 Aug 16, 2023
@phated phated deleted the phated/compile-lens branch August 16, 2023 18:10
TomAFrench added a commit that referenced this pull request Aug 16, 2023
* master:
  chore: update noir-source-resolver from `1.1.2` to `^1.1.3` (#2349)
  chore(ci): Avoid writing to cache in workflows triggered by the merge queue (#2341)
  chore(noir): Release 0.10.3 (#2344)
  feat(lsp): Add `Execute` code lens for `main` functions (#2330)
  feat(lsp): Add `Compile` code lens for `main` function and contracts (#2309)
  feat: Allow calling higher-order functions with closures (#2335)
TomAFrench added a commit that referenced this pull request Aug 17, 2023
* master: (25 commits)
  chore: update noir-source-resolver from `1.1.2` to `^1.1.3` (#2349)
  chore(ci): Avoid writing to cache in workflows triggered by the merge queue (#2341)
  chore(noir): Release 0.10.3 (#2344)
  feat(lsp): Add `Execute` code lens for `main` functions (#2330)
  feat(lsp): Add `Compile` code lens for `main` function and contracts (#2309)
  feat: Allow calling higher-order functions with closures (#2335)
  fix: Display warning if last expression of block is unused (#2314)
  chore(noir): Release 0.10.2 (#2343)
  fix: Prevent dead instruction elimination of brillig functions which may contain side-effects (#2340)
  chore: Separate integration tests for contracts and programs (#2339)
  chore: move orphaned integration tests to new directory (#2331)
  chore(noir): Release 0.10.1 (#2328)
  feat(ssa): Switch mem2reg pass to be per function rather than per block (#2243)
  feat(ssa): Perform dead instruction elimination on intrinsic functions (#2276)
  feat: Add full call stacks to runtime errors (#2310)
  chore(ci): fix mismatched input name to publish workflow (#2327)
  chore: add README for integration test structure (#2277)
  feat: Improved error message for unexpected return type (#2302)
  feat(stdlib): Implement `str` `as_bytes` and `into_bytes` function (#2298)
  chore(ci): automatically convert changelog entries to sentence case (#2325)
  ...
@Savio-Sou
Copy link
Collaborator

We have a Language Server page in our docs, so this should be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants