chore: Add stdlib to every crate as it is added to graph #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
force-pushed
the
phated/no-special-file-id
branch
from
56dd093 to
e547c45
Compare
TomAFrench
reviewed
Aug 23, 2023
phated
changed the title
phated
force-pushed
the
phated/no-special-file-id
branch
from
e27dc88 to
733acb8
Compare
phated
commented
Aug 23, 2023
TomAFrench
changed the title
phated
commented
Aug 23, 2023
|
Making this non-breaking again due to changes above. |
TomAFrench
approved these changes
Aug 24, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
TomAFrench
added a commit
that referenced
this pull request
Aug 24, 2023
* master: chore: improve error message for InternalError (#2429) chore: Add stdlib to every crate as it is added to graph (#2392) feat: create equivalence relationships for intermediate witnesses from multiplication (#2414) chore(ci): Fix version of `cross` to 0.2.5 (#2426) fix: Correct off-by-one errors in lexer spans (#2393)
TomAFrench
added a commit
that referenced
this pull request
Aug 25, 2023
* master: fix: Implement new mem2reg pass (#2420) feat(nargo): Support optional directory in git dependencies (#2436) fix(acir_gen): Pass accurate contents to slice inputs for bb func calls (#2435) fix(ssa): codegen missing check for unary minus (#2413) fix(lsp): Remove duplicated creation of lenses (#2433) feat: Add `test(should_fail)` attribute for tests that are meant to fail (#2418) chore: improve error message for InternalError (#2429) chore: Add stdlib to every crate as it is added to graph (#2392)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #1681
Summary*
This removes the stdlib propagation from the internals of
check_crateand instead adds it to each crate in the CrateGraph as they are being added. We can do this because the Stdlib CrateId is a separate variant and we know that each crate should have access to it.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.