chore: remove temporary workaround for issue 1354 in swcurve.nr and tecurve.nr

[ghost]

Description

In the curvegroup::mul function of both swcurve.nr and tecurve.nr, we previously had a temporary workaround for issue 1354. This workaround involved manually copying bits from a bit representation of the field element n into an array n_as_bits. However, this workaround is no longer necessary as issue 1354 has been resolved.

PR Checklist

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[TomAFrench]

#1354

The bit arrays don't need to be mutable anymore. Can you remove this?

[ghost]

It appears that this pull request is dependent on the resolution of issue #2336.

minimal example:

fn hello<N>(array: [u1; N]) {
    for i in 0..N {}
}

fn main() {
    let slice: [u1] = [].push_back(1).push_back(2);
    hello(slice);
}

The application panicked (crashed).
Message:  Non-numeric type variable used in expression expecting a value
Location: crates/noirc_frontend/src/monomorphization/mod.rs:631

This is a bug. We may have already fixed this in newer versions of Nargo so try searching for similar issues at https://github.com/noir-lang/noir/issues/.
If there isn't an open issue for this bug, consider opening one at https://github.com/noir-lang/noir/issues/new?labels=bug&template=bug_report.yml

[kevaundray]

2336 has been closed as completed, please merge master into this branch

[kevaundray]

@f01dab1e can this be updated? I see that Jake's message in the issue you opened had not been resolved

[ghost]

@kevaundray, It seems that the array is actually a slice, and we cannot determine its size, which is why the error Could not determine loop bound at compile-time is occurring.

The "to_le_bits" function returns a slice.

The "bit_mul" function accepts an array (we are trying to convert a slice to an array), and at this point, we encounter a failure because we don't know the size: Could not determine loop bound at compile-time.

[github-actions]

Thank you for your contribution to the Noir language.

Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.

Thanks for your understanding.