feat(ssa): Replace values which have previously been constrained with simplified value #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
reviewed
Aug 30, 2023
5 tasks
TomAFrench
force-pushed
the
replace_constrained_values
branch
from
0f041ba to
1f12948
Compare
TomAFrench
force-pushed
the
replace_constrained_values
branch
2 times, most recently
from
5b50fb1 to
1590a79
Compare
TomAFrench
force-pushed
the
replace_constrained_values
branch
from
1590a79 to
2813ad6
Compare
|
This is ready for a re-review now. CI failure is unrelated to this PR. |
jfecher
reviewed
Sep 5, 2023
jfecher
reviewed
Sep 5, 2023
TomAFrench
commented
Sep 5, 2023
Co-authored-by: jfecher <jake@aztecprotocol.com>
jfecher
approved these changes
Sep 5, 2023
TomAFrench
added a commit
that referenced
this pull request
Sep 5, 2023
* master: fix(aztec): fix compilation of `aztec_library.rs` (#2567) feat(ssa): Replace values which have previously been constrained with simplified value (#2483) fix: Black box func slice handling (#2562) chore: Temporarily disable `noir_wasm` test (#2566) fix: Make def collector ordering more deterministic (#2515) chore: refactor `constant_folding` pass (#2533) chore: Cleanup mem2reg pass (#2531) chore: Replace hashers of hashmaps in dfg with fxhashes (#2490) chore: remove duplicate span from FunctionReturnType (#2546)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR adds a mapping for
ValueIds which are constrained to be equal within the current block. When resolving the inputs of instructions, we can then alternate between the standard resolution and checking for an constrained equivalence in this mapping.This optimization is especially useful for situations where we want to perform slice indexing such as in https://github.com/AztecProtocol/aztec-packages/blob/94053e44f4d2a702fe9066bfff3cdd35e6d1b645/yarn-project/noir-libs/noir-aztec/src/messaging/l1_to_l2_message.nr#L47-L65. Rather than checking the slice length on each access, we can assert the length of the slice once and skip all of the other checks.
We must keep a separate cache rather than inserting these equivalences into the
dfgas otherwise we'll apply these simplifications before (and inside) the constrain statement which enforces it.Documentation
This PR requires documentation updates when merged.
Additional Context
The bytecode for a number of programs has increased due to previous PRs which didn't update the committed bytecode. The changes from this optimzation are in e4c9634
PR Checklist*
cargo fmton default settings.