chore: Skip unrolling loops for Brillig #2587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Sep 7, 2023
|
|
||
| // We abort on error if the runtime is Acir, because ACIR does not | ||
| // know how to handle loops even with constant bounds. | ||
| let abort_on_error = function_runtime == RuntimeType::Acir; |
There was a problem hiding this comment.
left this in here, though it should always be true
sirasistant
approved these changes
Sep 7, 2023
5 tasks
|
forgot to merge this, I like Jake's comments better so closing this in favour of #2590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This increases the amount of memory we use and at the moment the compiler doesn't seem to be handling this well.
The tradeoff as discussed with @jfecher is that the mem2reg pass becomes less useful.
Problem*
Resolves
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.