Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): split build and tests jobs in abi_wasm.yml #2714

Closed
wants to merge 12 commits into from

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Summary*

This separates the building and testing of noirc_abi_wasm which, among other things, allows easier rerunning in the case of a flakey test failure.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench force-pushed the tf/split-build-and-test branch from 391e91a to 9d9c947 Compare September 15, 2023 10:33
@TomAFrench
Copy link
Member Author

TomAFrench commented Sep 15, 2023

I've found the underlying cause for this issue.

When we were downloading the artifact, we were overwriting the package.json with the one from the build outputs. This had some fields filtered out of it which resulted in the yarn behaviour.

@TomAFrench
Copy link
Member Author

Oof, requested review too soon.

@TomAFrench TomAFrench force-pushed the tf/split-build-and-test branch from f2cf2ea to 9647178 Compare September 15, 2023 14:52
* master:
  chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718)
  chore: clippy fixes (#2719)
@TomAFrench TomAFrench mentioned this pull request Sep 15, 2023
5 tasks
@TomAFrench TomAFrench closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants