chore(ci): ensure that the artifact rebuilding PR will run CI #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
approved these changes
Sep 25, 2023
TomAFrench
added a commit
that referenced
this pull request
Sep 26, 2023
* master: (31 commits) fix: Conditionally run the "Create or Update PR" step in acir artifacts rebuild workflow (#2849) fix: lack of cjs package version (#2848) chore: delete unnecessary nix files (#2840) chore!: `generateWitness` now returns a serialized witness file (#2842) chore: fix `acvm_js` linting and tests (#2834) feat: remove redundant predicate from brillig quotients (#2784) chore: Fix dependencies in acvm_js and remove local lock file (#2833) chore: add acvm_js to integration build chore: update discord link (#2831) chore: discard changes in nargo directory chore: Update ACIR artifacts (#2810) chore: yarn install chore: Remove acvm tracking workflow (#2829) add acvm_js to workspace - remove acvm-eslint - rename acvm-test to acvm-js-test chore: delete acvm-release workflow chore: merge flake.nix files and remove inner workspace (#2826) chore(ci): remove stale job steps (#2816) chore(ci): ensure that the artifact rebuilding PR will run CI (#2824) feat(traits): Implement trait bounds typechecker + monomorphizer passes (#2717) ...
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Currently the PR to automatically update the build artifacts is being committed by the
github-actionsbot but this doesn't allow for workflows to run on the created PR. A workaround for this is for us to make the PR as @kevaundray which will then run CI as usual.The alternative for this is that we have to always close and reopen the PR before CI will run.
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.