Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add MPL-2.0 to allow list for deny action #2924

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Oct 1, 2023

Description

The deny action is failing on master due to some of our dependencies using MPL-2.0 and also an issue with respects to duplicate entries in Cargo.toml.

For the first, I added MPL-2.0 to deny.toml and the for the second I regenerated the .lock file, but this got rolled back for now. This PR only adds the MPL license

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray changed the title chore: fix deny action fix: Add MPL-2.0 to allow list for deny action and regenerate Cargo.lock file Oct 1, 2023
Cargo.toml Outdated Show resolved Hide resolved
@kevaundray
Copy link
Contributor Author

kevaundray commented Oct 1, 2023

I had to run cargo update --precise for quite a few dependencies -- which is why the actions are failing. Might be worth it to remove the Cargo.lock change and just add the MPL-2.0 change for now

EDIT: Did this instead

@kevaundray kevaundray changed the title fix: Add MPL-2.0 to allow list for deny action and regenerate Cargo.lock file fix: Add MPL-2.0 to allow list for deny action Oct 1, 2023
@TomAFrench TomAFrench changed the title fix: Add MPL-2.0 to allow list for deny action chore: Add MPL-2.0 to allow list for deny action Oct 2, 2023
@TomAFrench TomAFrench enabled auto-merge October 2, 2023 08:58
@TomAFrench TomAFrench added this pull request to the merge queue Oct 2, 2023
Merged via the queue into master with commit 7c8c834 Oct 2, 2023
@TomAFrench TomAFrench deleted the kw/fix-deny branch October 2, 2023 09:22
Sakapoi pushed a commit to Sakapoi/noir_fork that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants