chore: strip initialization of unused memory blocks from ACIR #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vezenovm
reviewed
Oct 4, 2023
Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
vezenovm
approved these changes
Oct 4, 2023
TomAFrench
added a commit
that referenced
this pull request
Oct 6, 2023
* master: (31 commits) chore: run tests for `noir_wasm` in node under default resolver (#3020) chore: align versions for js packages (#3019) fix: Fix aztec library after nargo fmt (#3014) chore: simplify ES workspace build and publish (#2989) fix: fix method `program_counter`, change method signature (#3012) fix: ACIR optimizer should update assertion messages (#3010) fix: check for overflow with hexadecimal inputs (#3004) feat(traits): Add trait impl for buildin types (#2964) feat(traits): added checks for duplicated trait associated items (types, consts, functions) (#2927) chore(formatter): trim spaces after opening brace (#3005) feat: format infix expressions (#3001) feat: provide formatting subcommand (#2640) chore: Noir.js interface accepts a stuct of public inputs and proof (#2992) fix: Transform hir before type checks (#2994) fix!: Make for loops a statement (#2975) feat: Add aztec selectors for event structs (#2983) fix(traits)!: trait functions with a default implementation must not be followed by a semicolon (#2987) chore: strip initialization of unused memory blocks from ACIR (#2985) chore: clippy fix (#2986) chore(ci): replace webdriver with playwright (#2988) ...
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
…ang#2985) Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR adds an optimization pass which removes any
MemoryInitopcodes from the ACIR which don't get acted on by anyMemoryOpopcodes.Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.