Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add experimental REPL-based debugger #2995

Merged
merged 26 commits into from
Oct 13, 2023
Merged

feat: Add experimental REPL-based debugger #2995

merged 26 commits into from
Oct 13, 2023

Commits on Oct 5, 2023

  1. First cut at implementing a debug command for nargo 

    Allows stepping through the ACIR opcodes, showing the current opcode and mapped
source location.
    @ggiraldez @mverzilli
    ggiraldez authored and mverzilli committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    363aa86 View commit details
    Browse the repository at this point in the history

  2. Use ForeignCallExecutor from debug op

    @mverzilli
    mverzilli committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    21571a8 View commit details
    Browse the repository at this point in the history

  3. feat(nargo): Stubbed out debug repl with placeholder command

    @nthiad @mverzilli
    nthiad authored and mverzilli committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ab59aca View commit details
    Browse the repository at this point in the history

  4. refactor debug logic around ReplContext methods

    @nthiad @mverzilli
    nthiad authored and mverzilli committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    afa0964 View commit details
    Browse the repository at this point in the history

  5. Move all debugger code into a new crate under tooling/debugger

    @ggiraldez @mverzilli
    ggiraldez authored and mverzilli committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a9804fa View commit details
    Browse the repository at this point in the history

  6. Cargo.lock update

    @mverzilli
    mverzilli committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    67c5615 View commit details
    Browse the repository at this point in the history

  7. Port repl to easy-repl (not compiling)

    @mverzilli
    mverzilli committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    8a61999 View commit details
    Browse the repository at this point in the history

  8. Fix compilation with easy-repl

    @ggiraldez @mverzilli
    ggiraldez authored and mverzilli committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    43fecda View commit details
    Browse the repository at this point in the history

  9. Format

    @mverzilli
    mverzilli committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c176f77 View commit details
    Browse the repository at this point in the history

  10. Update tooling/nargo_cli/src/cli/mod.rs 

    Co-authored-by: kevaundray <kevtheappdev@gmail.com>
    @mverzilli @kevaundray
    mverzilli and kevaundray authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    da1657e View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Fix panic when trying to show status and the execution finished 

    Also use a Cell (instead of a RefCell) to store the solved status.
    @ggiraldez
    ggiraldez committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    f0717e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Merge branch 'master' into debug-prototype-repl-easy

    @mverzilli
    mverzilli committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4ada9fa View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Merge branch 'master' into debug-prototype-repl-easy

    @mverzilli
    mverzilli committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    6de5370 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into debug-prototype-repl-easy

    @mverzilli
    mverzilli committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8edf3e4 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Update tooling/nargo_cli/src/cli/debug_cmd.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @mverzilli @TomAFrench
    mverzilli and TomAFrench authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    258d009 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'refs/remotes/origin/debug-prototype-rep… 

    …l-easy' into debug-prototype-repl-easy
    @mverzilli
    mverzilli committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    5b13eff View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Debugger: explicitly restrict to binary packages

    @mverzilli
    mverzilli committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    449d16e View commit details
    Browse the repository at this point in the history

  2. Handle debug halt as expected result

    @mverzilli
    mverzilli committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c3a3138 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into debug-prototype-repl-easy

    @mverzilli
    mverzilli committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    a687efd View commit details
    Browse the repository at this point in the history

  4. Update tooling/debugger/src/lib.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @mverzilli @TomAFrench
    mverzilli and TomAFrench authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e4586b0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'debug-prototype-repl-easy' of github.com:manastech/noir… 

    … into debug-prototype-repl-easy
    @mverzilli
    mverzilli committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    0cf36ef View commit details
    Browse the repository at this point in the history

  6. Bring up to date to latest ACVM/Brillig refactors

    @mverzilli
    mverzilli committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    dd30bca View commit details
    Browse the repository at this point in the history

  7. chore: Simplify selection/validation of package for debugging

    @ggiraldez
    ggiraldez committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    f20d0e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. chore: apply clippy suggestions

    @ggiraldez
    ggiraldez committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    8622d70 View commit details
    Browse the repository at this point in the history

  2. Update tooling/debugger/src/lib.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @mverzilli @TomAFrench
    mverzilli and TomAFrench authored Oct 13, 2023
    Configuration menu
    Copy the full SHA
    f0b3ecf View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into debug-prototype-repl-easy

    @mverzilli
    mverzilli committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    c61df1a View commit details
    Browse the repository at this point in the history