Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make backend instantiate available #3071

Merged
merged 1 commit into from
Oct 10, 2023
Merged

chore: make backend instantiate available #3071

merged 1 commit into from
Oct 10, 2023

Conversation

kobyhallx
Copy link
Contributor

Description

Makes BarretenbergBackend.instantiate() available for user to call.

This makes api consistent with noir_js approach to lazilly instatiate when user does not choose to do so upfront, while enabling user to initialize before any execution steps.

This is to wrap: Cleanup Noir.js#2910

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kobyhallx kobyhallx enabled auto-merge October 10, 2023 12:18
@kobyhallx kobyhallx added this pull request to the merge queue Oct 10, 2023
Merged via the queue into master with commit cc48300 Oct 10, 2023
27 checks passed
@kobyhallx kobyhallx deleted the kh-ch-backend-barretenberg-initialize branch October 10, 2023 13:03
TomAFrench pushed a commit that referenced this pull request Oct 12, 2023
@kobyhallx @TomAFrench
chore: make backend instantiate available (#3071)
4707288
Sakapoi pushed a commit to Sakapoi/noir_fork that referenced this pull request Oct 19, 2023
@kobyhallx @Sakapoi
chore: make backend instantiate available (noir-lang#3071)
12c903e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobyhallx @TomAFrench