Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up if #3110

Closed
wants to merge 9 commits into from
Closed

chore: set up if #3110

wants to merge 9 commits into from

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Oct 11, 2023

Description

Problem*

Resolves #2993

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member

I'm inclined to omit this until we have proper line breaking support, I think it would be sad to lose the ability to do let min = if a < b { a } else { b };

@jonybur jonybur closed this Oct 11, 2023
@jonybur
Copy link
Contributor Author

jonybur commented Oct 11, 2023

Omitting until we have proper line breaking support

@jonybur jonybur reopened this Oct 11, 2023
@jonybur jonybur closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epic: Complete Noir formatter implementation
2 participants