chore(debugger): avoid taking ownership of Circuit when building debug context #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mverzilli
force-pushed
the
debug-prototype-minor-borrow-refactor
branch
from
e6fb622
to
38ad0db
Compare
TomAFrench
reviewed
Oct 13, 2023
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
|
Ah, this is missing out the removal of the clone of the opcodes. This is already mostly through the merge queue so I'll add it to a different PR. |
TomAFrench
added a commit
that referenced
this pull request
Oct 13, 2023
* master: chore(debugger): avoid taking ownership of Circuit when building debug context (#3147)
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
…g context (noir-lang#3147) Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
This is a follow up PR to #2995, addressing this comment: #2995 (comment).
Summary
Passes circuit to debugger by reference instead of moving it.
PR Checklist
cargo fmton default settings.