chore: refactor LSP crate layout #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobyhallx
approved these changes
Oct 16, 2023
TomAFrench
added a commit
that referenced
this pull request
Oct 16, 2023
* master: chore: refactor LSP crate layout (#3170)
Sakapoi
pushed a commit
to Sakapoi/noir_fork
that referenced
this pull request
Oct 19, 2023
signorecello
pushed a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR continues the refactoring of the layout of the LSP crate. The handlers for requests and notifications have been split into separate files. So has the
BlackBoxFunctionSolverimplementation.I've also replaced some of the usage of for-loops and explicit vec pushing with iterators.
There should be zero changes in functionality in this PR.
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.