fix: modify assert(x)
span to cover entire statement
#3177
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #3175
Summary*
This PR fixes #3175 but I'm not sure if it's exactly the route we want to go down in general. I'm now setting the span of the constraint's
condition
to cover the entire statement rather than purely the condition alone. This is consistent with how we handleassert_eq
but feels like I'm misusing this.Perhaps we should assign explicit spans to statements rather than relying on using the spans of their fields.
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.