Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): Update PR template per new documentation workflow #3241

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

Savio-Sou
Copy link
Collaborator

Description

Context

To better promote secure and best development practices through documentation, Noir's contribution workflow now requires code authors to include documentation updates per their code changes (if applicable) in the same PRs.

The workflow would be very helpful for capturing design philosophies, contexts, details and caveats from the original authors in the Noir documentation that otherwise could easily go missing in translation.

Summary*

This PR updates the GitHub PR template to reflect the new workflow.

Additionally the PR also trims the verbose comments in the template.

Additional Context

Related effort: #3162

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@Savio-Sou Savio-Sou added enhancement New feature or request documentation Improvements or additions to documentation labels Oct 20, 2023
@Savio-Sou Savio-Sou requested a review from kevaundray October 20, 2023 22:45
@signorecello signorecello self-requested a review October 24, 2023 10:08
Copy link
Contributor

@signorecello signorecello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reviewing but I think we should have @kevaundray's input on this

@Savio-Sou Savio-Sou added this pull request to the merge queue Oct 25, 2023
Merged via the queue into master with commit 2c9fe26 Oct 25, 2023
27 checks passed
@Savio-Sou Savio-Sou deleted the ss/pr-template-docs branch October 25, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants