Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: method specialization #3268

Merged
merged 3 commits into from
Oct 24, 2023
Merged

chore: method specialization #3268

merged 3 commits into from
Oct 24, 2023

Conversation

signorecello
Copy link
Contributor

Description

Documents the usage of method specialisation

Problem*

Resolves #3238

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

docs CI troll

I'm a bot, beep boop 🤖

Deployment Status: Failed ❌

Deployment didn't succeed. Please check logs below and resolve the issue 🧐

Netlify Status

@signorecello signorecello changed the title docs: method specialization feat: method specialization Oct 24, 2023
@signorecello signorecello changed the title feat: method specialization chore: method specialization Oct 24, 2023
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jfecher jfecher enabled auto-merge October 24, 2023 15:21
@jfecher jfecher added this pull request to the merge queue Oct 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2023
@jfecher jfecher added this pull request to the merge queue Oct 24, 2023
Merged via the queue into master with commit 77deab4 Oct 24, 2023
31 checks passed
@jfecher jfecher deleted the zpedro/method_spec branch October 24, 2023 16:58
TomAFrench added a commit that referenced this pull request Oct 24, 2023
* master:
  feat: implement `bound_constraint_with_offset` in terms of `AcirVar`s (#3233)
  fix: Add size checks to integer literals (#3236)
  chore: add constrain formatter (#3272)
  chore: standardize workflow triggers (#3277)
  fix: Fix lexer error formatting (#3274)
  chore: method specialization (#3268)
  feat: add crate for pub modifier (#3271)
  chore: fix empty constructor formatting (#3265)
@signorecello
Copy link
Contributor Author

I have no idea how 451f4c6 still passed the CI, but it definitely broke master

guipublic pushed a commit that referenced this pull request Oct 27, 2023
Co-authored-by: jfecher <jake@aztecprotocol.com>
guipublic pushed a commit that referenced this pull request Oct 30, 2023
Co-authored-by: jfecher <jake@aztecprotocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document PR #3087 - impl specialization
2 participants