-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: method specialization #3268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Oct 24, 2023
signorecello
changed the title
feat: method specialization
chore: method specialization
Oct 24, 2023
jfecher
reviewed
Oct 24, 2023
jfecher
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 24, 2023
TomAFrench
added a commit
that referenced
this pull request
Oct 24, 2023
* master: feat: implement `bound_constraint_with_offset` in terms of `AcirVar`s (#3233) fix: Add size checks to integer literals (#3236) chore: add constrain formatter (#3272) chore: standardize workflow triggers (#3277) fix: Fix lexer error formatting (#3274) chore: method specialization (#3268) feat: add crate for pub modifier (#3271) chore: fix empty constructor formatting (#3265)
I have no idea how 451f4c6 still passed the CI, but it definitely broke master |
guipublic
pushed a commit
that referenced
this pull request
Oct 27, 2023
Co-authored-by: jfecher <jake@aztecprotocol.com>
guipublic
pushed a commit
that referenced
this pull request
Oct 30, 2023
Co-authored-by: jfecher <jake@aztecprotocol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documents the usage of method specialisation
Problem*
Resolves #3238