Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adding fix to master branch #3279

Merged
merged 5 commits into from
Oct 24, 2023
Merged

chore: adding fix to master branch #3279

merged 5 commits into from
Oct 24, 2023

Conversation

signorecello
Copy link
Contributor

Problem*

Somehow a previous PR passed CI without a valid deployment. This broke master.

Summary*

  • Undos the mess that broke master
  • Tries to stop continuing on error if deployment fails, I don't even know why i had it there in the first place

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023 •
edited
Loading

It's Alive!

I'm a bot, beep boop 🤖

Deployment Status: Success!

Netlify Status

Preview

🌐 View Deployment Preview

@signorecello
Copy link
Contributor Author

ok seems like this does the trick

@kevaundray kevaundray enabled auto-merge October 24, 2023 21:46
@kevaundray kevaundray added this pull request to the merge queue Oct 24, 2023
Merged via the queue into master with commit 0ecf0d5 Oct 24, 2023
28 checks passed
@kevaundray kevaundray deleted the zpedro/fixing_master_docs branch October 24, 2023 22:17
TomAFrench added a commit that referenced this pull request Oct 25, 2023
@TomAFrench
Merge branch 'master' into tf/optimize-constant-div
67797dc 
* master:
  chore: pinning NoirJS guide versions to 0.17.0 and adding note on noir-examples (#3266)
  chore: Release Noir(0.18.0) (#3242)
  chore: turn off `aztec` flag by default (#3280)
  feat!: expose pedersen hash in acir and bb solver (#3269)
  chore: adding fix to master branch (#3279)
guipublic pushed a commit that referenced this pull request Oct 26, 2023
@signorecello @guipublic
chore: adding fix to master branch (#3279)
ea88441
guipublic pushed a commit that referenced this pull request Oct 27, 2023
@signorecello @guipublic
chore: adding fix to master branch (#3279)
e6ca7b5
guipublic pushed a commit that referenced this pull request Oct 30, 2023
@signorecello @guipublic
chore: adding fix to master branch (#3279)
33c083e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

@critesjosh critesjosh Awaiting requested review from critesjosh

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@signorecello @kevaundray