Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove default empty features array #3285

Merged
merged 1 commit into from
Oct 25, 2023
Merged

chore: remove default empty features array #3285

merged 1 commit into from
Oct 25, 2023

Conversation

alexghr
Copy link
Contributor

@alexghr alexghr commented Oct 25, 2023

Description

This PR fixes 'Publish Noir ES Packages' CI job by removing the empty 'default' features.

Problem*

error: while parsing a TOML string: [error] toml::insert_value: value ("default") already exists.

Summary*

Documentation

N/A

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray enabled auto-merge October 25, 2023 13:14
@kevaundray kevaundray added this pull request to the merge queue Oct 25, 2023
Merged via the queue into master with commit 3919619 Oct 25, 2023
26 checks passed
@kevaundray kevaundray deleted the alexg/fix/public-aztec-builds branch October 25, 2023 14:41
guipublic pushed a commit that referenced this pull request Oct 26, 2023
@alexghr @guipublic
chore: remove default empty features array (#3285)
6a98579
guipublic pushed a commit that referenced this pull request Oct 26, 2023
@alexghr @guipublic
chore: remove default empty features array (#3285)
f31da68
guipublic pushed a commit that referenced this pull request Oct 27, 2023
@alexghr @guipublic
chore: remove default empty features array (#3285)
5639698
guipublic pushed a commit that referenced this pull request Oct 30, 2023
@alexghr @guipublic
chore: remove default empty features array (#3285)
7a534e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexghr @kevaundray