chore!: bump MSRV to 1.71.1

.github/workflows/auto-pr-rebuild-script.yml

@@ -44,7 +44,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.66.0
+        uses: dtolnay/rust-toolchain@1.71.1
 
       - uses: Swatinem/rust-cache@v2
         with:

.github/workflows/formatting.yml

@@ -32,7 +32,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.66.0
+        uses: dtolnay/rust-toolchain@1.71.1
         with:
           targets: ${{ matrix.target }}
           components: clippy, rustfmt

.github/workflows/gates_report.yml

@@ -18,7 +18,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.66.0
+        uses: dtolnay/rust-toolchain@1.71.1
 
       - uses: Swatinem/rust-cache@v2
         with:

.github/workflows/publish-acvm.yml

@@ -18,9 +18,7 @@ jobs:
           ref: ${{ inputs.acvm-ref }}
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@master
-        with:
-          toolchain: 1.66.0
+        uses: dtolnay/rust-toolchain@1.71.1
 
       # These steps are in a specific order so crate dependencies are updated first
       - name: Publish acir_field

.github/workflows/publish-nargo.yml

@@ -45,7 +45,7 @@ jobs:
           echo "MACOSX_DEPLOYMENT_TARGET=$(xcrun -sdk macosx$(sw_vers -productVersion) --show-sdk-platform-version)" >> $GITHUB_ENV
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.66.0
+        uses: dtolnay/rust-toolchain@1.71.1
         with:
           targets: ${{ matrix.target }}
 
@@ -128,7 +128,7 @@ jobs:
           ref: ${{ inputs.tag || env.GITHUB_REF }}
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.66.0
+        uses: dtolnay/rust-toolchain@1.71.1
         with:
           targets: ${{ matrix.target }}
 

.github/workflows/test-integration.yml

@@ -19,7 +19,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.66.0
+        uses: dtolnay/rust-toolchain@1.71.1
 
       - uses: Swatinem/rust-cache@v2
         with:

.github/workflows/test-noir-js.yml

@@ -21,7 +21,7 @@ jobs:
         uses: ./.github/actions/setup
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.66.0
+        uses: dtolnay/rust-toolchain@1.71.1
         with:
           targets: wasm32-unknown-unknown
 

.github/workflows/test-noir_wasm.yml

@@ -23,7 +23,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.66.0
+        uses: dtolnay/rust-toolchain@1.71.1
 
       - uses: Swatinem/rust-cache@v2
         with:

.github/workflows/test-rust-workspace.yml

@@ -31,7 +31,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.66.0
+        uses: dtolnay/rust-toolchain@1.71.1
         with:
           targets: ${{ matrix.target }}
 

README.md

@@ -54,7 +54,7 @@ Concretely the following items are on the road map:
 
 ## Minimum Rust version
 
-This crate's minimum supported rustc version is 1.66.0.
+This crate's minimum supported rustc version is 1.71.1.
 
 ## Working on this project
 

docs/docs/getting_started/00_nargo_installation.md

@@ -45,7 +45,7 @@
 
 Done, you should have the latest version working. You can check with `nargo --version`.
 
 You can also install nightlies, specific versions
 or branches, check out the [noirup repository](https://github.com/noir-lang/noirup) for more
 information.
 
@@ -140,9 +140,9 @@
 
 ### Option 3: Compile from Source
 
 Due to the large number of native dependencies, Noir projects uses [Nix](https://nixos.org/) and [direnv](https://direnv.net/) to streamline the development experience. It helps mitigating ssues commonly associated with dependency management, such as conflicts between required package versions for different projects (often referred to as "dependency hell").
 
 Combined with direnv, which automatically sets or unsets environment variables based on the directory, it further simplifies the development process by seamlessly integrating with the developer's shell, facilitating an efficient and reliable workflow for managing and deploying Noir projects with multiple dependencies.
 
 #### Setting up your environment
 
@@ -163,7 +163,7 @@
 ```
 
 4. Add direnv to your shell following [their guide](https://direnv.net/docs/hook.html).
    1. For bash or zshell, add `eval "$(direnv hook bash)"` or `eval "$(direnv hook zsh)"` to your ~/.bashrc or ~/.zshrc file, respectively.
 5. Restart your shell.
 
 #### Shell & editor experience
@@ -205,7 +205,7 @@
 #### Building and testing
 
 Assuming you are using `direnv` to populate your environment, building and testing the project can be done
-with the typical `cargo build`, `cargo test`, and `cargo clippy` commands. You'll notice that the `cargo` version matches the version we specify in `flake.nix`, which is 1.66.0 at the time of this writing.
+with the typical `cargo build`, `cargo test`, and `cargo clippy` commands. You'll notice that the `cargo` version matches the version we specify in `rust-toolchain.toml`, which is 1.71.1 at the time of this writing.
 
 If you want to build the entire project in an isolated sandbox, you can use Nix commands:
 
@@ -220,7 +220,7 @@
 
 ### Option 4: WSL (for Windows)
 
 The default backend for Noir (Barretenberg) doesn't provide Windows binaries at this time. For that reason, Noir cannot be installed nativerly. However, it is available by using Windows Subsystem for Linux (WSL).
 
 Step 1: Follow the instructions [here](https://learn.microsoft.com/en-us/windows/wsl/install) to install and run WSL.
 

flake.nix

@@ -44,7 +44,7 @@
 
       rustToolchain = fenix.packages.${system}.fromToolchainFile {
         file = ./rust-toolchain.toml;
-        sha256 = "sha256-Zk2rxv6vwKFkTTidgjPm6gDsseVmmljVt201H7zuDkk=";
+        sha256 = "sha256-R0F0Risbr74xg9mEYydyebx/z0Wu6HI0/KWwrV30vZo=";
       };
 
       craneLib = (crane.mkLib pkgs).overrideToolchain rustToolchain;

rust-toolchain.toml

@@ -1,5 +1,5 @@
 [toolchain]
-channel = "1.66.1"
+channel = "1.71.1"
 components = [ "rust-src" ]
 targets = [ "wasm32-unknown-unknown", "wasm32-wasi", "aarch64-apple-darwin" ]
 profile = "default"

tooling/nargo/build.rs

@@ -2,8 +2,8 @@ use rustc_version::{version, Version};
 
 fn check_rustc_version() {
     assert!(
-        version().unwrap() >= Version::parse("1.66.0").unwrap(),
-        "The minimal supported rustc version is 1.66.0."
+        version().unwrap() >= Version::parse("1.71.1").unwrap(),
+        "The minimal supported rustc version is 1.71.1."
     );
 }
 

tooling/nargo_cli/build.rs

@@ -6,8 +6,8 @@ use std::{env, fs};
 
 fn check_rustc_version() {
     assert!(
-        version().unwrap() >= Version::parse("1.66.0").unwrap(),
-        "The minimal supported rustc version is 1.66.0."
+        version().unwrap() >= Version::parse("1.71.1").unwrap(),
+        "The minimal supported rustc version is 1.71.1."
     );
 }
 

tooling/nargo_fmt/src/utils.rs

@@ -89,7 +89,7 @@
         let starts_with_single_line_comment = leading_trimmed.starts_with("//");
 
         if ends_with_block_comment {
             let comment_end = leading_trimmed.rfind(|c| c == '/').unwrap();
 
             if leading[comment_end..].contains('\n') {
                 different_line = true;
@@ -124,7 +124,6 @@
         Lexer::new(self)
             .skip_comments(false)
             .flatten()
-            .into_iter()
             .find_map(|spanned| f(spanned.token()).then(|| spanned.to_span().end()))
     }
 }