Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Re-open #3258 #3410

Merged
merged 98 commits into from
Nov 3, 2023
Merged

chore: Re-open #3258 #3410

merged 98 commits into from
Nov 3, 2023

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Nov 2, 2023 •
edited
Loading

Description

Problem*

This reopens #3258 which was inadvertently merged early into its parent PR (#3187) before the parent was merged into master. Reference #3187 (comment) for more details

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm
enabled dynamic indices on nested arrays
c2f2f62
@vezenovm
remove debug
45b3787
@vezenovm
working non-homogenous arr accesses for block params
7ccf8e9
@vezenovm
add array_set, broken, need to maintain structure from SSA for accura…
d5d16d7 
…te index
@vezenovm
merge conflcits w/ master
ec54e01
@vezenovm
working non-homogenous arrays using internal type element size array,…
e2eff9b 
… heavy cleanup still needed
@vezenovm
cleanup lots of debug and move const index access into its own method
219c8f2
@vezenovm
updating array_get and array_set to reduce repeated code
3195325
@vezenovm
restrict dynamic indices for non-homogenous slices
8fb3bb1
@vezenovm
cleanup array_get_value
469c333
@vezenovm
add internal_memory_blocks map
0648142
@vezenovm
do not make separate bool for handle_constant_index
b99f0e2
@vezenovm
fetch dummy value with predicate index
5784170
@vezenovm
flatten the index once for both array_set and array_get, do not modif…
05f35c6 
…y modify the predicate index for the non-dummy val
@vezenovm
remove first_elem param
f2dd702
@vezenovm
initial slice changes with fetch flat size from SSA values, need to g…
490f5af 
…et element type size array correct
@vezenovm
merge master
0037867
@vezenovm
initial working nested dynamic slices
3636bc6
@vezenovm
cleanup and fmt
31e7bc2
@vezenovm
cargo clippy and fmt
4354b76
@vezenovm
merge conflicts w/ master
87e8314
@vezenovm
remove boolean AcirType
658d234
@vezenovm
remove deaad code not in master
408ac2c
@vezenovm
better solution for fetching nested slice with multiple slice mergesr
22ce20c
@vezenovm
bring back assert in nested_array_dynamic
686640e
@vezenovm
add assert to nested_slice_dynamic test
626616b
@vezenovm
cleanup w/ copy_dynamic_array method
f60183c
@vezenovm
starting test for slices in struct fields
be5dc79
@vezenovm
more initial debugging for adding slices to struct fields
a7fde3e
@vezenovm
basic slice struct fields working, but broken for struct fields of di…
d1c9192 
…fferent lengths
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023 •
edited
Loading

Changes to circuit sizes

Generated at commit: 4b89a0852aaecb2a7346f7fa8f8a25aabb9a9285, compared to commit: e026319fc25763d30781b90e6a4454ddb5d3bc7b

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
slice_struct_field +4,657 ❌ +314.45% +15,997 ❌ +166.22%
slice_dynamic_index +84 ❌ +3.49% +432 ❌ +4.11%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
slice_struct_field 6,138 (+4,657) +314.45% 25,621 (+15,997) +166.22%
slice_dynamic_index 2,490 (+84) +3.49% 10,940 (+432) +4.11%

@vezenovm vezenovm changed the title chore: Diff for #3258 chore: Re-open #3258 Nov 2, 2023
@vezenovm vezenovm changed the base branch from master to mv/slice-struct-fields November 2, 2023 20:25
@vezenovm vezenovm marked this pull request as ready for review November 2, 2023 20:29
@vezenovm vezenovm mentioned this pull request Nov 2, 2023
Merged
5 tasks
Base automatically changed from mv/slice-struct-fields to master November 3, 2023 16:41
@TomAFrench TomAFrench enabled auto-merge November 3, 2023 16:44
@TomAFrench TomAFrench added this pull request to the merge queue Nov 3, 2023
Merged via the queue into master with commit 48cf1a7 Nov 3, 2023
32 checks passed
@TomAFrench TomAFrench deleted the mv/fill-slices-pass branch November 3, 2023 17:38
TomAFrench added a commit that referenced this pull request Nov 14, 2023
@vezenovm @TomAFrench @jfecher
chore: Re-open #3258 (#3410)
77cd98b 
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <tom@tomfren.ch>
Co-authored-by: jfecher <jake@aztecprotocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vezenovm @jfecher @TomAFrench