Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove include-keys option #3692

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: remove include-keys option #3692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/docs/nargo/01_commands.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@

| Option | Description |
| --------------------- | ------------------------------------------------------------ |
| `--include-keys` | Include Proving and Verification keys in the build artifacts |
| `--package <PACKAGE>` | The name of the package to compile |
| `--workspace` | Compile all packages in the workspace |
| `--print-acir` | Display the ACIR for compiled circuit |
Expand Down Expand Up @@ -209,7 +208,7 @@
## `nargo test [TEST_NAME]`

Nargo will automatically compile and run any functions which have the decorator `#[test]` on them if
you run `nargo test`. To print `println` statements in tests, use the `--show-output` flag.

Check warning on line 211 in docs/docs/nargo/01_commands.md

View workflow job for this annotation

GitHub Actions / Spellcheck / Spellcheck 

Unknown word (println)

Takes an optional `--exact` flag which allows you to select tests based on an exact name.

Expand All @@ -219,7 +218,7 @@

| Option | Description |
| --------------------- | -------------------------------------- |
| `--show-output` | Display output of `println` statements |

Check warning on line 221 in docs/docs/nargo/01_commands.md

View workflow job for this annotation

GitHub Actions / Spellcheck / Spellcheck 

Unknown word (println)
| `--exact` | Only run tests that match exactly |
| `--package <PACKAGE>` | The name of the package to test |
| `--workspace` | Test all packages in the workspace |
Expand Down
4 changes: 0 additions & 4 deletions tooling/nargo_cli/src/cli/compile_cmd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@ const BACKEND_IDENTIFIER: &str = "acvm-backend-barretenberg";
/// Compile the program and its secret execution trace into ACIR format
#[derive(Debug, Clone, Args)]
pub(crate) struct CompileCommand {
/// Include Proving and Verification keys in the build artifacts.
#[arg(long)]
include_keys: bool,

/// The name of the package to compile
#[clap(long, conflicts_with = "workspace")]
package: Option<CrateName>,
Expand Down
Loading