feat: Add context-centric based API for noir_wasm #3798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s already been populated
…de their source code
…les into the file manager anymore
…laceholders like panic! and format! do
… always has its data
# Description This removes FileManager from add_file and uses add_file_with_source ## Problem\* Resolves <!-- Link to GitHub Issue --> ## Summary\* ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
kevaundray
commented
Dec 13, 2023
TomAFrench
reviewed
Dec 13, 2023
|
Need to add js tests |
TomAFrench
changed the title
… the compile_ api
|
Added tests and also a new method called compile_ which exposes the same API as compile, but internally uses the context based API -- (this still non-breaking) |
kevaundray
added a commit
that referenced
this pull request
Dec 18, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>0.22.0</summary> ## [0.22.0](v0.21.0...v0.22.0) (2023-12-18) ### ⚠ BREAKING CHANGES * Remove unused methods on ACIR opcodes ([#3841](#3841)) * Remove backend field from artifacts ([#3819](#3819)) * Remove partial backend feature ([#3805](#3805)) ### Features * Add context-centric based API for noir_wasm ([#3798](#3798)) ([19155d0](19155d0)) ### Miscellaneous Chores * Remove backend field from artifacts ([#3819](#3819)) ([fa1cf5f](fa1cf5f)) * Remove partial backend feature ([#3805](#3805)) ([0383100](0383100)) * Remove unused methods on ACIR opcodes ([#3841](#3841)) ([9e5d0e8](9e5d0e8)) </details> <details><summary>0.38.0</summary> ## [0.38.0](v0.37.1...v0.38.0) (2023-12-18) ### ⚠ BREAKING CHANGES * Remove unused methods on ACIR opcodes ([#3841](#3841)) * Remove partial backend feature ([#3805](#3805)) ### Features * Aztec-packages ([#3754](#3754)) ([c043265](c043265)) * Speed up transformation of debug messages ([#3815](#3815)) ([2a8af1e](2a8af1e)) ### Bug Fixes * Deserialize odd length hex literals ([#3747](#3747)) ([4000fb2](4000fb2)) ### Miscellaneous Chores * Remove partial backend feature ([#3805](#3805)) ([0383100](0383100)) * Remove unused methods on ACIR opcodes ([#3841](#3841)) ([9e5d0e8](9e5d0e8)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently this PR is not breaking
This adds an API that maps closer to the API we'd have in the CLI or atleast one that differs less with the native version. One can imagine a shared Context object and in nargo_cli the main difference is the PathToSourceMap struct that gets passed in for example.
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.