-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Try using traits for FileManager [DO NOT MERGE] #3845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merges in changes from #3846 |
Made a PR to build off of this and it seems that to get a clean API, we need to at the least:
|
Until a follow-up PR can be built which shows how we would use the FileManager trait in a clean way, I'd be okay with not merging this just yet |
kevaundray
changed the title
chore: Try using traits for FileManager
chore: Try using traits for FileManager [DO NOT MERGE]
Dec 17, 2023
I'm going to close this as stale. Handling these merge conflicts will basically require a rewrite anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the need for an actual file manager in the compiler. The compiler instead defines an interface/trait that abstracts this away.
The current impl just copies the methods from FileManager, I'd imagine that we'd want to make the methods less specific to a file system, but for now if this looks good, I think its a future todo, since we rely on being able have segments for what we are calling path.
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.