fix: operator overloading & static trait method references resolving to generic impls

compiler/noirc_frontend/src/hir/def_collector/dc_crate.rs

@@ -455,7 +455,7 @@
         .collect()
 }
 
 // TODO(vitkov): Move this out of here and into type_check
 pub(crate) fn check_methods_signatures(
     resolver: &mut Resolver,
     impl_methods: &Vec<(FileId, FuncId)>,
@@ -474,18 +474,18 @@
     let trait_methods = std::mem::take(&mut the_trait.methods);
 
     for (file_id, func_id) in impl_methods {
-        let impl_method = resolver.interner.function_meta(func_id);
         let func_name = resolver.interner.function_name(func_id).to_owned();
 
-        let mut typecheck_errors = Vec::new();
-
         // This is None in the case where the impl block has a method that's not part of the trait.
         // If that's the case, a `MethodNotInTrait` error has already been thrown, and we can ignore
         // the impl method, since there's nothing in the trait to match its signature against.
         if let Some(trait_method) =
             trait_methods.iter().find(|method| method.name.0.contents == func_name)
         {
-            let impl_function_type = impl_method.typ.instantiate(resolver.interner);
+            let mut typecheck_errors = Vec::new();
+            let impl_method = resolver.interner.function_meta(func_id);
+
+            let (impl_function_type, _) = impl_method.typ.instantiate(resolver.interner);
 
             let impl_method_generic_count =
                 impl_method.typ.generic_count() - trait_impl_generic_count;
@@ -505,7 +505,7 @@
                 errors.push((error.into(), *file_id));
             }
 
-            if let Type::Function(impl_params, _, _) = impl_function_type.0 {
+            if let Type::Function(impl_params, _, _) = impl_function_type {
                 if trait_method.arguments().len() == impl_params.len() {
                     // Check the parameters of the impl method against the parameters of the trait method
                     let args = trait_method.arguments().iter();

compiler/noirc_frontend/src/hir_def/traits.rs

@@ -65,6 +65,7 @@ pub struct Trait {
     pub self_type_typevar_id: TypeVariableId,
     pub self_type_typevar: TypeVariable,
 }
+
 #[derive(Debug)]
 pub struct TraitImpl {
     pub ident: Ident,