Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Evaluation of dynamic assert messages #4101

Merged
merged 72 commits into from
Feb 1, 2024
Merged

feat: Evaluation of dynamic assert messages #4101

merged 72 commits into from
Feb 1, 2024

Commits on Jan 17, 2024

  1. initial updates to make assert_message not a string literal

    @vezenovm
    vezenovm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a523278 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mv/assert-msg-fmtstr

    @vezenovm
    vezenovm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    31b6e55 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. working resolution of assert messages and runtime

    @vezenovm
    vezenovm committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    84ec1bc View commit details
    Browse the repository at this point in the history

  2. remove old impl

    @vezenovm
    vezenovm committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0a084c4 View commit details
    Browse the repository at this point in the history

  3. revert debugging changes for brillig inputs

    @vezenovm
    vezenovm committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    c581cee View commit details
    Browse the repository at this point in the history

  4. cargo fmt

    @vezenovm
    vezenovm committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    73e48fb View commit details
    Browse the repository at this point in the history

  5. remove old ocmment

    @vezenovm
    vezenovm committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0c46345 View commit details
    Browse the repository at this point in the history

  6. cargo clippy and cleanup

    @vezenovm
    vezenovm committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    1cf135d View commit details
    Browse the repository at this point in the history

  7. cleanup old comments and initial debugging for brillig assert message

    @vezenovm
    vezenovm committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    3123241 View commit details
    Browse the repository at this point in the history

  8. improved usage of From trait for ForeignCallResults

    @vezenovm
    vezenovm committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    08d8922 View commit details
    Browse the repository at this point in the history

  9. resolve merge conflicts

    @vezenovm
    vezenovm committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    3284b99 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. start switching order of evaluation of resolve_assert_message as to n… 

    …ot have to change the brillig VM too much
    @vezenovm
    vezenovm committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    83605d8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into mv/assert-msg-fmtstr

    @vezenovm
    vezenovm committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    7fdf5be View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. switch order of execution

    @vezenovm
    vezenovm committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f131b96 View commit details
    Browse the repository at this point in the history

  2. update parser tests and some cleanup

    @vezenovm
    vezenovm committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f253cd2 View commit details
    Browse the repository at this point in the history

  3. cargo clippy

    @vezenovm
    vezenovm committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    e149ede View commit details
    Browse the repository at this point in the history

  4. add back debug logs lines that were removed

    @vezenovm
    vezenovm committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    8eb77ad View commit details
    Browse the repository at this point in the history

  5. added compile failure tests

    @vezenovm
    vezenovm committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d0234d2 View commit details
    Browse the repository at this point in the history

  6. move transformation of call expression to resolution rather than have… 

    … it be in the macro
    @vezenovm
    vezenovm committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    0f0cbe0 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into mv/assert-msg-fmtstr

    @vezenovm
    vezenovm committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    845e269 View commit details
    Browse the repository at this point in the history

  8. handle parser rrs

    @vezenovm
    vezenovm committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    85a40c4 View commit details
    Browse the repository at this point in the history

  9. fix create_mock

    @vezenovm
    vezenovm committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    e42cb9c View commit details
    Browse the repository at this point in the history

  10. move to non-optional expr

    @vezenovm
    vezenovm committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ec87b69 View commit details
    Browse the repository at this point in the history

  11. clippy

    @vezenovm
    vezenovm committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    bc317a0 View commit details
    Browse the repository at this point in the history

  12. clear out circuits w/ only brillig

    @vezenovm
    vezenovm committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    9284490 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. update compile_empty_success test

    @vezenovm
    vezenovm committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    4333637 View commit details
    Browse the repository at this point in the history

  2. fix format

    @vezenovm
    vezenovm committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    9bc00eb View commit details
    Browse the repository at this point in the history

  3. cleanup resolve assert message

    @vezenovm
    vezenovm committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    f3083c8 View commit details
    Browse the repository at this point in the history

  4. update debugger handle_foreign_call

    @vezenovm
    vezenovm committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    185aba1 View commit details
    Browse the repository at this point in the history

  5. cargo fmt

    @vezenovm
    vezenovm committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    27ea4d9 View commit details
    Browse the repository at this point in the history

  6. fix frontend tests, but acvm_js tests still failing

    @vezenovm
    vezenovm committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    0c7ff78 View commit details
    Browse the repository at this point in the history

  7. Update tooling/nargo/src/ops/execute.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @vezenovm @TomAFrench
    vezenovm and TomAFrench authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    720e470 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. some initial switches to putting resolve_assert_message under a predi… 

    …cate, still have to make call instr atomic w/ SSA
    @vezenovm
    vezenovm committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    8698083 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/mv/assert-msg-fmtstr' into mv/as… 

    …sert-msg-fmtstr
    @vezenovm
    vezenovm committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    8458f83 View commit details
    Browse the repository at this point in the history

  3. accept changes

    @vezenovm
    vezenovm committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    1a3ea85 View commit details
    Browse the repository at this point in the history

  4. missing merge edit

    @vezenovm
    vezenovm committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    480297a View commit details
    Browse the repository at this point in the history

  5. remove unused imports

    @vezenovm
    vezenovm committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    8de9539 View commit details
    Browse the repository at this point in the history

  6. remove old dbg

    @vezenovm
    vezenovm committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    86cab04 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. switch assert_message call instruction to be atomic with SSA and add … 

    …a predicate check
    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    7afc317 View commit details
    Browse the repository at this point in the history

  2. cleanup decompose_constrain

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    55de71f View commit details
    Browse the repository at this point in the history

  3. some comment cleanup

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    3ebc34a View commit details
    Browse the repository at this point in the history

  4. remove old comments

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    c0d3403 View commit details
    Browse the repository at this point in the history

  5. resolve merge conflicts

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    49e7118 View commit details
    Browse the repository at this point in the history

  6. cargo fmt

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    9944a83 View commit details
    Browse the repository at this point in the history

  7. reorganize codegen of constrain error

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    282a7d7 View commit details
    Browse the repository at this point in the history

  8. defunc cleanup

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    4cd9255 View commit details
    Browse the repository at this point in the history

  9. cleanup

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    9796a1b View commit details
    Browse the repository at this point in the history

  10. cleanup brillig assert message gen:

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    8579816 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into mv/assert-msg-fmtstr

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    5170bc1 View commit details
    Browse the repository at this point in the history

  12. macro errs update

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ae06f9e View commit details
    Browse the repository at this point in the history

  13. add an expect func to option

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    4e4d273 View commit details
    Browse the repository at this point in the history

  14. leave option expect for separate branch

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    e516c27 View commit details
    Browse the repository at this point in the history

  15. Update compiler/noirc_evaluator/src/ssa/opt/defunctionalize.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @vezenovm @TomAFrench
    vezenovm and TomAFrench authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    0c77f8f View commit details
    Browse the repository at this point in the history

  16. fixup git suggestion

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    5cd9335 View commit details
    Browse the repository at this point in the history

  17. use AssertMessageMacro when disable_macros is enabled

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    c8170f3 View commit details
    Browse the repository at this point in the history

  18. chore: reduce diff and fix clippy warnings

    @TomAFrench
    TomAFrench committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ae23e5c View commit details
    Browse the repository at this point in the history

  19. chore: reduce diff

    @TomAFrench
    TomAFrench committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    5e0e198 View commit details
    Browse the repository at this point in the history

  20. format constrain err better

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    fa6b50c View commit details
    Browse the repository at this point in the history

  21. Update compiler/noirc_evaluator/src/ssa/ssa_gen/mod.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @vezenovm @TomAFrench
    vezenovm and TomAFrench authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    f5598fe View commit details
    Browse the repository at this point in the history

  22. cargo fmt

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    d3c2f0e View commit details
    Browse the repository at this point in the history

  23. fix old test updates

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    bb34b45 View commit details
    Browse the repository at this point in the history

  24. remove old comment

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    819c95a View commit details
    Browse the repository at this point in the history

  25. reduce diff

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    c62bec8 View commit details
    Browse the repository at this point in the history

  26. update assert docs

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    7f174dc View commit details
    Browse the repository at this point in the history

  27. chore: remove some indentation

    @TomAFrench
    TomAFrench committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    dd056a1 View commit details
    Browse the repository at this point in the history

  28. noir js assert_lt test to show usage of resolve_assert_message

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    757c740 View commit details
    Browse the repository at this point in the history

  29. Merge remote-tracking branch 'origin/mv/assert-msg-fmtstr' into mv/as… 

    …sert-msg-fmtstr
    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    545923e View commit details
    Browse the repository at this point in the history

  30. improve comment

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    e002ba2 View commit details
    Browse the repository at this point in the history

  31. add assert_msg_runtime execution failure test to noirJS

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    c6fe900 View commit details
    Browse the repository at this point in the history

  32. prettier

    @vezenovm
    vezenovm committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    1d06de2 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Apply suggestions from code review

    @TomAFrench
    TomAFrench authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a48f065 View commit details
    Browse the repository at this point in the history

  2. chore: delete unnecessary files

    @TomAFrench
    TomAFrench committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    6f27d40 View commit details
    Browse the repository at this point in the history