Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove hack in increment_array_reference_count #4265

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: Remove hack in increment_array_reference_count #4265

merged 1 commit into from
Feb 5, 2024

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Feb 5, 2024

Description

Problem*

A followup to #4210

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm vezenovm mentioned this pull request Feb 5, 2024
Merged
5 tasks
@vezenovm vezenovm changed the title remove hack in increment_array_reference_count fix: Remove hack in increment_array_reference_count Feb 5, 2024
@vezenovm vezenovm requested a review from jfecher February 5, 2024 17:30
jfecher
jfecher approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure if this will pass all cases but I think it is good to merge since it passes the test cases we do know about.

@jfecher jfecher merged commit d331ee2 into jf/fix-incrc-assign Feb 5, 2024
31 of 32 checks passed
@jfecher jfecher deleted the mv/fix-incrc-review branch February 5, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vezenovm @jfecher