-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Test ubuntu-large
runner
#4305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFGGGGGGG
Oof, integration tests are still taking a while. We can split the browser and node tests to runn on different runners to help with this. |
As an alternative to this. It seems like most of the time is spent on the debugger tests, we may be able to just look into why these are so slow (although maybe unavoidable due to the sheer number of foreign calls being performed.) |
…4306) # Description ## Problem\* Resolves <!-- Link to GitHub Issue --> ## Summary\* This should help cut CI times to remove the new bottleneck after #4305 ## Additional Context ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
This machine is kinda insane. We're spending 35.81s for the fully debugger test suite whereas on the standard runner test cases take ~11s EACH. |
Gonna close this for now. I don't think we can get Javascript tests down to match this so the larger runner is unnecessary. |
Description
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.