Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary dev dependency from noir_wasm #4349

Merged
merged 1 commit into from
Feb 13, 2024
Merged

chore: remove unnecessary dev dependency from noir_wasm #4349

merged 1 commit into from
Feb 13, 2024

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

noir_wasm doesn't use noirc_abi so we can remove this dependency.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench added this pull request to the merge queue Feb 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2024
@TomAFrench TomAFrench added this pull request to the merge queue Feb 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2024
@TomAFrench TomAFrench added this pull request to the merge queue Feb 13, 2024
Merged via the queue into master with commit fff0b98 Feb 13, 2024
39 checks passed
@TomAFrench TomAFrench deleted the tf/remove-unnecessary-dev-dep branch February 13, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @jfecher