feat: separate slice and array types in the AST + as_slice builtin #4550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersand, updating stdlib, fixed nested slice for new type, found missing unification case, added more specific error for missing array length, debugging slice parser, added noirc_frontend test for slices, debugging stdlib failing to build
…fic black box functions, stdlib building
…type check case, updating test_programs, defaulting unknown array length to zero, cleanup debugging println, add utf8 decoding and serde error to execution json decoding error message, cargo clippy/fmt
…es for slices, fix slice literal in regression test
…e debugger error (timeout in brillig_cow_regression)
… wip implementing convert_ssa_as_slice
… to match similar ones, recreated debugger error in execution test
…of brillig length variable
…anup as_slice test
… out brillig and regular as_slice tests, cargo fmt/clippy
…ference counting changes on master, cargo clippy / fmt
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
… array lengths, support ArrayLen on acir var's when constant and the appropriate type, fix element type in generated ssa ir for as_slice, fix printer not distinguishing between slices and arrays, use slice literal instead of as_slice for merkle insert, update as_slice test with cases from debugging
|
Is this far enough along yet to get the performance results compared to master? |
|
comparing
|
michaeljklein
deleted the
michaeljklein/separate-slice-ast-builtin-as-slice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
This draft PR is a combination of:
to evaluate the performance effects of the
as_slicebuiltin.Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.