chore: fix docs builds on master #4593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
|
🚀 Deployed on https://65f9ec626a1991125317cc28--noir-docs.netlify.app |
|
FYI @noir-lang/developerrelations on Noir doc changes. |
TomAFrench
added a commit
that referenced
this pull request
Mar 20, 2024
* master: (28 commits) chore: fix assignees for opening issues based on CI (#4596) feat!: separating out array and slice types in the AST (#4504) chore: fix docs builds (#4593) chore: Standardise workspace JS dependencies (#4583) feat: Add `break` and `continue` in unconstrained code (#4569) chore: update deps (#4582) fix: Signed integer comparisons in brillig (#4579) chore: Add clarfiication on the difference in recursive aggregation circuits (#4567) feat: Sync from aztec-packages (#4573) fix: added error messages for passing oracles and references from unconstrained to constrained functions (#4570) feat: RC optimization pass (#4560) feat: add as_slice builtin function, add execution test (#4523) chore: making docs build before cutting versions (#4568) chore: fix docker test workflows (#4566) feat: allow usage of noir `#[test]` syntax in stdlib (#4553) feat: Add more impls on Option (#4549) chore: fixing some broken links (#4556) chore: separate tests for execution failures from compilation failures (#4559) feat: remove curly braces with fmt (#4529) fix: Make `nargo` the default binary for cargo run (#4554) ...
TomAFrench
added a commit
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Followup to #4568
Fixes https://github.com/noir-lang/noir/actions/runs/8347752784/job/22848198145#step:5:1324
Summary*
Looks like the typedoc plugin doesn't build transitive dependencies if they're reexported so we need to ensure that the ACVM crate is built and available.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.