feat(experimental): Implement comptime mut globals #4926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vezenovm
approved these changes
Apr 26, 2024
| span: let_stmt.pattern.span(), | ||
| }); | ||
| let span = let_stmt.pattern.span(); | ||
| self.push_err(ResolverError::AbiAttributeOusideContract { span }); |
There was a problem hiding this comment.
Looks like this is an old spelling error. Could we change it to Outside everywhere
| } | ||
|
|
||
| fn main() { | ||
| // Order of comptime evaluation between functions isn't guaranteed |
There was a problem hiding this comment.
Can we make this guaranteed? Of course this would be a follow-up
TomAFrench
approved these changes
Apr 29, 2024
| span: let_stmt.pattern.span(), | ||
| }); | ||
| let span = let_stmt.pattern.span(); | ||
| self.push_err(ResolverError::AbiAttributeOusideContract { span }); |
| } | ||
|
|
||
| fn main() { | ||
| // Order of comptime evaluation between functions isn't guaranteed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #4917
Summary*
Implements mutable comptime globals
Additional Context
Changes should be relatively straightforward - mostly parser changes to add parsing
mutto globals, resolution changes to track this and error if the global is not also comptime, etc. The one bug that was fixed is that globals were being re-evaluated in the interpreter each time which would reset their value whenever they were referenced. This has been fixed with a lookup check.Documentation*
Check one:
PR Checklist*
cargo fmton default settings.