Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove dep:: prefix #4946

Merged
merged 37 commits into from
Jun 17, 2024
Merged

feat!: remove dep:: prefix #4946

merged 37 commits into from
Jun 17, 2024

Commits on Apr 30, 2024

  1. use PathKind::Plain over Dep, remove PathKind::Dep, resolve both poss… 

    …ibilities when PathKind::Plain encountered, add test to ensure case never encountered in nargo_fmt, update path parsers, update unit tests and test_programs, cargo fmt/clippy
    @michaeljklein
    michaeljklein committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    167e153 View commit details
    Browse the repository at this point in the history

  2. removing from aztec_macros, expected-to-be failing test_programs, etc

    @michaeljklein
    michaeljklein committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    425116f View commit details
    Browse the repository at this point in the history

  3. only resolve path externally when unresolved internally, i.e. not whe… 

    …n other errors occur, make backwards compatible
    @michaeljklein
    michaeljklein committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ec7eb40 View commit details
    Browse the repository at this point in the history

  4. add PathKind::Dep back in 1) to ease distinguishing deprecated case, … 

    …2) so that it can be used for the '::' prefix later, add deprecation warning
    @michaeljklein
    michaeljklein committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    91e003e View commit details
    Browse the repository at this point in the history

  5. cargo fmt/clippy

    @michaeljklein
    michaeljklein committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    22ec8c7 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into michaeljklein/combine-dep-crate

    @michaeljklein
    michaeljklein authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7ad8d05 View commit details
    Browse the repository at this point in the history

  7. fix tests failing from deprecation warning

    @michaeljklein
    michaeljklein committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    552b29b View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Update compiler/noirc_frontend/src/parser/errors.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @michaeljklein @TomAFrench
    michaeljklein and TomAFrench authored May 1, 2024
    Configuration menu
    Copy the full SHA
    c8ba6f5 View commit details
    Browse the repository at this point in the history

  2. Update compiler/noirc_frontend/src/hir/resolution/import.rs 

    Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
    @michaeljklein @TomAFrench
    michaeljklein and TomAFrench authored May 1, 2024
    Configuration menu
    Copy the full SHA
    51bbb0e View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'master' into michaeljklein/combine-dep-crate

    @michaeljklein
    michaeljklein committed May 8, 2024
    Configuration menu
    Copy the full SHA
    3493069 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. wip responding to review comments, distinguish deprecated path kind f… 

    …rom '::path', only resolve plain path as external when the first segment isn't found, rename DepPathPrefixDeprecated -> LitDepPathPrefixDeprecated, add distinct parsing case for '::path' with tests, remove test missing a Nargo.toml, add test_programs for overlapping cases
    @michaeljklein
    michaeljklein committed May 9, 2024
    Configuration menu
    Copy the full SHA
    0da34b2 View commit details
    Browse the repository at this point in the history

  2. remove LitDep and associated warning, revert parser

    @michaeljklein
    michaeljklein committed May 9, 2024
    Configuration menu
    Copy the full SHA
    a00b775 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into michaeljklein/combine-dep-crate

    @michaeljklein
    michaeljklein authored May 9, 2024
    Configuration menu
    Copy the full SHA
    2c6b20b View commit details
    Browse the repository at this point in the history

  4. update previous-approach '::path' tests, simplify dep/mod overlap test

    @michaeljklein
    michaeljklein committed May 9, 2024
    Configuration menu
    Copy the full SHA
    97bfe72 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Merge branch 'master' into michaeljklein/combine-dep-crate

    @michaeljklein
    michaeljklein authored May 10, 2024
    Configuration menu
    Copy the full SHA
    b47f8b7 View commit details
    Browse the repository at this point in the history

  2. add test for external vs local import without 'dep::'

    @michaeljklein
    michaeljklein committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8a4d138 View commit details
    Browse the repository at this point in the history

  3. convert overlapping_dep_and_mod to a compile failure by moving expect… 

    …ed overlap from dep::foo::bar != foo::bar to foo::bar/foo::baz (overlapping module name)
    @michaeljklein
    michaeljklein committed May 10, 2024
    Configuration menu
    Copy the full SHA
    085d1f6 View commit details
    Browse the repository at this point in the history

  4. add 'overlapping_dep_and_mod*' tests to excluded_dirs in formatting t… 

    …est (as they're a type of workspace test)
    @michaeljklein
    michaeljklein committed May 10, 2024
    Configuration menu
    Copy the full SHA
    11f6235 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into michaeljklein/combine-dep-crate

    @michaeljklein
    michaeljklein authored May 10, 2024
    Configuration menu
    Copy the full SHA
    d374c04 View commit details
    Browse the repository at this point in the history

  6. nargo fmt

    @michaeljklein
    michaeljklein committed May 10, 2024
    Configuration menu
    Copy the full SHA
    268490f View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge branch 'master' into michaeljklein/combine-dep-crate

    @michaeljklein
    michaeljklein authored May 14, 2024
    Configuration menu
    Copy the full SHA
    0842de8 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Merge branch 'master' into michaeljklein/combine-dep-crate

    @michaeljklein
    michaeljklein committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a4437f5 View commit details
    Browse the repository at this point in the history

  2. nargo fmt

    @michaeljklein
    michaeljklein committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    fb82de4 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Merge branch 'master' into michaeljklein/combine-dep-crate

    @michaeljklein
    michaeljklein authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    3d36751 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Merge branch 'master' into michaeljklein/combine-dep-crate

    @michaeljklein
    michaeljklein authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    cea5f46 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Merge branch 'master' into michaeljklein/combine-dep-crate 

    * master:
  chore: add no-predicate to hash implementations (#5253)
    @TomAFrench
    TomAFrench committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    fd1b873 View commit details
    Browse the repository at this point in the history

  2. chore: fmt

    @TomAFrench
    TomAFrench committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7b3eb42 View commit details
    Browse the repository at this point in the history

  3. chore: update new paths

    @TomAFrench
    TomAFrench committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9111c2a View commit details
    Browse the repository at this point in the history

  4. chore: fix naming of new test

    @TomAFrench
    TomAFrench committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    0a876b3 View commit details
    Browse the repository at this point in the history

  5. chore: restrict parallelism in rebuild.sh

    @TomAFrench
    TomAFrench committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    407b22a View commit details
    Browse the repository at this point in the history

  6. chore: remove useless use std statements

    @TomAFrench
    TomAFrench committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    ec2b819 View commit details
    Browse the repository at this point in the history

  7. chore: clean up straggler

    @TomAFrench
    TomAFrench committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    c51cdd6 View commit details
    Browse the repository at this point in the history

  8. chore: revert change to formatter test

    @TomAFrench
    TomAFrench committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    74526c4 View commit details
    Browse the repository at this point in the history

  9. Update compiler/noirc_frontend/src/parser/errors.rs

    @TomAFrench
    TomAFrench authored Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a53fb5c View commit details
    Browse the repository at this point in the history

  10. Update docs/docs/noir/concepts/data_types/slices.mdx

    @TomAFrench
    TomAFrench authored Jun 17, 2024
    Configuration menu
    Copy the full SHA
    ac9cdbc View commit details
    Browse the repository at this point in the history

  11. chore: revert changes to formatter

    @TomAFrench
    TomAFrench committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8816095 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'master' into michaeljklein/combine-dep-crate 

    * master:
  feat: Sync from aztec-packages (#5242)
  chore: replace `is_bn254` implementation to not rely on truncation of literals (#5247)
    @TomAFrench
    TomAFrench committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    787e020 View commit details
    Browse the repository at this point in the history