Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from aztec-packages #5048

Closed
wants to merge 3 commits into from
Closed

feat: Sync from aztec-packages #5048

wants to merge 3 commits into from

Commits on May 17, 2024

  1. chore: fix poor performance and long compile times in value_note.dere…

    …ment() (AztecProtocol/aztec-packages#6523)
    
    AztecProtocol/aztec-packages#6405 added a very
    complicated call (`get_npk_m_hash`) to `destroy_note`, not realizing
    that `destroy_note` is called in a loop by `decrement`. The loop
    unrolling caused multiple calls to this function, even though they all
    had the same arguments, ultimately resulting in humongous RAM usage
    during compilation (over 40GB just for this contract) and very
    compilation times (from 30s to multiple minutes).
    
    This PR fixes this simply inlining the code for `destroy_note` and
    fetching the key once at the beginning. It does worry me slightly
    however that such a large performance hit was not noticed - this likely
    affected test times as well.
    AztecBot committed May 17, 2024
    Configuration menu
    Copy the full SHA
    89b11ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8d96752 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Configuration menu
    Copy the full SHA
    1f50bdf View commit details
    Browse the repository at this point in the history