chore: Move turbofish changes to the elaborator #5094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
approved these changes
May 23, 2024
Co-authored-by: jfecher <jake@aztecprotocol.com>
Co-authored-by: jfecher <jake@aztecprotocol.com>
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 27, 2024
…r-lang/noir#5097) chore(docs): Link to evmdiff for supported EVM chains (noir-lang/noir#5107) chore: Avoid creating witness for simple multiplications (noir-lang/noir#5100) feat: Add intrinsic to get if running inside an unconstrained context (noir-lang/noir#5098) chore: Move turbofish changes to the elaborator (noir-lang/noir#5094) fix: Apply self type from generic trait constraint before instantiating identifiers (noir-lang/noir#5087) chore: reactivate gates report (noir-lang/noir#5084) chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081) chore: update `nargo info` table to remove circuit size column feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080) fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941) chore(experimental): Elaborate globals (noir-lang/noir#5069) chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066) feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058) chore: use `bbup` to install `bb` (noir-lang/noir#5073) feat: Sync from aztec-packages (noir-lang/noir#5070) chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071) feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050) fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 27, 2024
…5097) chore(docs): Link to evmdiff for supported EVM chains (noir-lang/noir#5107) chore: Avoid creating witness for simple multiplications (noir-lang/noir#5100) feat: Add intrinsic to get if running inside an unconstrained context (noir-lang/noir#5098) chore: Move turbofish changes to the elaborator (noir-lang/noir#5094) fix: Apply self type from generic trait constraint before instantiating identifiers (noir-lang/noir#5087) chore: reactivate gates report (noir-lang/noir#5084) chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081) chore: update `nargo info` table to remove circuit size column feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080) fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941) chore(experimental): Elaborate globals (noir-lang/noir#5069) chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066) feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058) chore: use `bbup` to install `bb` (noir-lang/noir#5073) feat: Sync from aztec-packages (noir-lang/noir#5070) chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071) feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050) fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049)
sirasistant
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
May 27, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: Consider block parameters in variable liveness (noir-lang/noir#5097) chore(docs): Link to evmdiff for supported EVM chains (noir-lang/noir#5107) chore: Avoid creating witness for simple multiplications (noir-lang/noir#5100) feat: Add intrinsic to get if running inside an unconstrained context (noir-lang/noir#5098) chore: Move turbofish changes to the elaborator (noir-lang/noir#5094) fix: Apply self type from generic trait constraint before instantiating identifiers (noir-lang/noir#5087) chore: reactivate gates report (noir-lang/noir#5084) chore: automatically clear any unwanted directories in `test_programs` (noir-lang/noir#5081) chore: update `nargo info` table to remove circuit size column feat: Activate return_data in ACIR opcodes (noir-lang/noir#5080) fix: Use plain integer addresses for opcodes in DAP disassembly view (noir-lang/noir#4941) chore(experimental): Elaborate globals (noir-lang/noir#5069) chore(experimental): Add types and traits to the elaborator (noir-lang/noir#5066) feat: remove conditional compilation of `bn254_blackbox_solver` (noir-lang/noir#5058) chore: use `bbup` to install `bb` (noir-lang/noir#5073) feat: Sync from aztec-packages (noir-lang/noir#5070) chore: update docs to represent zksync supporting necessary precompiles (noir-lang/noir#5071) feat(stdlib)!: eddsa function using turbofish (noir-lang/noir#5050) fix(frontend): Correctly monomorphize turbofish functions (noir-lang/noir#5049) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: sirasistant <sirasistant@gmail.com>
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 28, 2024
# Description ## Problem\* Follow-up to #5094 ## Summary\* This was missed when moving over changes due to the turbofish operator over to the elaborato.r ## Additional Context ## Documentation\* Check one: - [X] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [X] I have tested the changes locally. - [X] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Moving #3542, #5041, and #5087 to the elaborator
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.